RFR: 8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos [v2]
duke
duke at openjdk.org
Thu Oct 3 02:24:34 UTC 2024
On Wed, 2 Oct 2024 08:31:13 GMT, Manukumar V S <mvs at openjdk.org> wrote:
>> javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos.
>> This could be because of a synchronisation issue in the test.
>>
>> Fix: I have refactored the test to have a CountDownLatch to monitor the ProgressMonitor and when it reaches 20%, it will be triggered. I have also removed the ProgressMonitor update logic execution from EDT as it would block the EDT sometimes. Also added a proper frame disposal mechanism.
>>
>> Testing:
>> This is properly tested multiple times in all available platforms in mach5.
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments fixed : Formatting changes
@manukumarvs
Your change (at version 11ea52d8ad5f881a110f62213aed7f801caafe2a) is now ready to be sponsored by a Committer.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21293#issuecomment-2390369503
More information about the client-libs-dev
mailing list