RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v7]

Alexander Zvegintsev azvegint at openjdk.org
Thu Oct 3 17:46:40 UTC 2024


On Thu, 3 Oct 2024 16:48:24 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are updated in this PR:
>> 
>> 1. 	test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
>> 2. 	test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
>> 3. 	test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
>> 4. 	test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java
>
> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
> 
>  - jtreg tag
>  - Merge master
>  - test instruction updated
>  - removed validate()
>  - review fixes, updated problemlist
>  - Merge master
>  - problemlist updated
>  - eof newline
>  - checkbox tests

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java line 55:

> 53:                       .title("Test Instructions")
> 54:                       .instructions(INSTRUCTIONS)
> 55:                       .rows((int) INSTRUCTIONS.lines().count() + 1)

Suggestion:


I think it is no longer necessary, also in CheckboxPreferredSizeTest.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21094#pullrequestreview-2346310132
PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1786626672


More information about the client-libs-dev mailing list