RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v7]

Harshitha Onkar honkar at openjdk.org
Thu Oct 3 17:50:39 UTC 2024


On Thu, 3 Oct 2024 17:41:07 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
>> 
>>  - jtreg tag
>>  - Merge master
>>  - test instruction updated
>>  - removed validate()
>>  - review fixes, updated problemlist
>>  - Merge master
>>  - problemlist updated
>>  - eof newline
>>  - checkbox tests
>
> test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java line 55:
> 
>> 53:                       .title("Test Instructions")
>> 54:                       .instructions(INSTRUCTIONS)
>> 55:                       .rows((int) INSTRUCTIONS.lines().count() + 1)
> 
> Suggestion:
> 
> 
> I think it is no longer necessary, also in CheckboxPreferredSizeTest.

Noted. I'll remove it in future PRs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1786634066


More information about the client-libs-dev mailing list