RFR: 8341984: Use PassFailJFrame for TimeChangeButtonClickTest.java [v2]

[Harshitha Onkar]

On Tue, 15 Oct 2024 22:12:08 GMT, Phil Race <prr at openjdk.org> wrote:

>> Actually, I think what is happening is that when the time is set forward an hour (+2 hours forward from 1 hour behind as in instructions) the test will automatically time out because it thinks an hour has passed. I thought initially it was me being slow on changing the time settings but even if you do everything quickly the test always fails exactly when you set the time forward.
>> 
>> So I think with the way the timeout is implemented the test is broken with PassFailJFrame.
>
> What an .. interesting .. test. No idea what this does to the jtreg test harness too.
> FWIW I think this test should be deleted rather than trying to make it nicer.

> Actually, I think what is happening is that when the time is set forward an hour (+2 hours forward from 1 hour behind as in instructions) the test will automatically time out because it thinks an hour has passed. I thought initially it was me being slow on changing the time settings but even if you do everything quickly the test always fails exactly when you set the time forward.

Good catch. I hadn't noticed PFJ timeout.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21476#discussion_r1802116824