RFR: 8341984: Use PassFailJFrame for TimeChangeButtonClickTest.java [v2]

[Alexey Ivanov]

On Tue, 15 Oct 2024 23:13:12 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> What an .. interesting .. test. No idea what this does to the jtreg test harness too.
>> FWIW I think this test should be deleted rather than trying to make it nicer.
>
>> Actually, I think what is happening is that when the time is set forward an hour (+2 hours forward from 1 hour behind as in instructions) the test will automatically time out because it thinks an hour has passed. I thought initially it was me being slow on changing the time settings but even if you do everything quickly the test always fails exactly when you set the time forward.
> 
> Good catch. I hadn't noticed PFJ timeout.

Indeed, the test does not play nicely with timeout in `PassFailJFrame`.

The workaround could be to pause the timeout. In addition to that, we could set the timeout to 15 minutes. If the user changes time not -1 / +2 hours but rather -5 / +10 minutes, it should be enough.

> What an .. interesting .. test. No idea what this does to the jtreg test harness too.

The jtreg test harness turns off its timeout for manual tests, as far as I understand. By the time, the test finishes, the time on the system should be correct again.

> FWIW I think this test should be deleted rather than trying to make it nicer.

Another option could be to mark the test with `@ignore` so that it's not run regularly. The test could still be useful; even though changing time isn't common…

I wonder if going to/from DST reproduces the problem in [JDK-7096375](https://bugs.openjdk.org/browse/JDK-7096375) for which the test was written.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21476#discussion_r1806854693