RFR: 8342098: Write a test to compare the images [v2]
Naveen Narayanan
duke at openjdk.org
Thu Oct 17 17:25:34 UTC 2024
On Thu, 17 Oct 2024 17:19:53 GMT, Naveen Narayanan <duke at openjdk.org> wrote:
>> test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 47:
>>
>>> 45: public class ScreenCaptureRobotTest {
>>> 46:
>>> 47: private static int delay = 500;
>>
>> I don't think we need `delay`, since it's used only once. Can directly use the value.
>
> @TejeshR13
> Right, local failures are observed.
> But passes in Mach5
> https://mach5.us.oracle.com/mdash/jobs/nnnaraya-client-colocation-20241017-1708-18342774
To avoid a Magic Number, as a better practice
May be replacing `delay` with a constant makes it more meaningful ?
private static final long DELAY = 500
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1805146054
More information about the client-libs-dev
mailing list