RFR: 8342098: Write a test to compare the images [v2]
Phil Race
prr at openjdk.org
Thu Oct 17 18:51:34 UTC 2024
On Thu, 17 Oct 2024 10:10:02 GMT, Tejesh R <tr at openjdk.org> wrote:
>> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8342098: Updated review comments
>
> test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 47:
>
>> 45: public class ScreenCaptureRobotTest {
>> 46:
>> 47: private static int delay = 500;
>
> I don't think we need `delay`, since it's used only once. Can directly use the value.
> @TejeshR13 Right, local failures may be observed. But tests passes in jtreg & CI for Windows.
Why might local failures be observed ?? That's a very concerning statement.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1805264960
More information about the client-libs-dev
mailing list