RFR: 8342098: Write a test to compare the images [v3]
Naveen Narayanan
duke at openjdk.org
Mon Oct 21 17:01:27 UTC 2024
On Mon, 21 Oct 2024 13:31:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8342098: Updated review comments
>
> test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 82:
>
>> 80: frame.add(canvas);
>> 81: frame.setSize(300, 200);
>> 82: frame.setLocation(100, 100);
>
> Is it important?
> I'd rather put the frame into the centre of the screen as most new tests do.
Changed to setLocationRelativeTo()
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1809177197
More information about the client-libs-dev
mailing list