RFR: 8342098: Write a test to compare the images [v3]

Naveen Narayanan duke at openjdk.org
Thu Oct 24 15:38:07 UTC 2024


On Mon, 21 Oct 2024 13:52:25 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8342098: Updated review comments
>
> test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 1:
> 
>> 1: /*
> 
> Does this test has a value at all?
> 
> Does this test verifies the functionality of the `Robot` class? Many other tests rely on `Robot.createScreenCapture` to capture part of the screen. If `Robot` captures something unexpected, all such tests should fail.

@aivanov-jdk 
We are carrying out colocation of tests from Functional to Regression suite.
This test is for comparing two images pixelwise, one is robot Captured while other is Real image.
May be there is no exact matching test existing with same context.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1815248584


More information about the client-libs-dev mailing list