RFR: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java

[Harshitha Onkar]

On Fri, 25 Oct 2024 15:48:58 GMT, Daniel Gredler <duke at openjdk.org> wrote:

> There are multiple issue with this test case
> 1) Parser error due to yesno in @run main/manual=yesno
> 2) User can only compare the UI rendering and compare with the print out. User can't mark the test as pass or fail due to pass or fail buttons are missing.
> 3) When the test is executed using jtreg after user click on the print button on the print dialog the whole test UIs ( frames) gets dispose and user cannot compare the printout with the UI. But this works as expected in test is running individually using java PrintTextTest

Is the manual test verified on all platforms?

test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 43:

> 41: import javax.swing.*;
> 42: 
> 43: public class PrintTextTest extends Component implements Printable {

Please expand wild card imports and update the license copyright year.

`* Copyright (c) 2007, 2024, Oracle and/or its affiliates.`

test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 70:

> 68:     boolean useFM;
> 69: 
> 70:     public static void main(String args[]) throws Exception {

Java style arrays

Suggestion:

    public static void main(String[] args) throws Exception {

test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 205:

> 203:         });
> 204: 
> 205:         JFrame f = new JFrame();

Add frame title

Suggestion:

        JFrame f = new JFrame("PrintTextTest");

-------------

PR Review: https://git.openjdk.org/jdk/pull/21716#pullrequestreview-2408880725
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1825042641
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1825043567
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1825051798