RFR: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java [v2]

Daniel Gredler duke at openjdk.org
Thu Oct 31 21:36:02 UTC 2024


On Thu, 31 Oct 2024 19:06:23 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Daniel Gredler has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright year, imports, array style, frame title
>
> test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 43:
> 
>> 41: import javax.swing.*;
>> 42: 
>> 43: public class PrintTextTest extends Component implements Printable {
> 
> Please expand wild card imports and update the license copyright year.
> 
> `* Copyright (c) 2007, 2024, Oracle and/or its affiliates.`

Thanks for the feedback -- done.

> test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 70:
> 
>> 68:     boolean useFM;
>> 69: 
>> 70:     public static void main(String args[]) throws Exception {
> 
> Java style arrays
> 
> Suggestion:
> 
>     public static void main(String[] args) throws Exception {

Done.

> test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 205:
> 
>> 203:         });
>> 204: 
>> 205:         JFrame f = new JFrame();
> 
> Add frame title
> 
> Suggestion:
> 
>         JFrame f = new JFrame("PrintTextTest");

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1825184409
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1825185868
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1825186015


More information about the client-libs-dev mailing list