RFR: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize [v4]
Manukumar V S
mvs at openjdk.org
Wed Sep 4 07:17:19 UTC 2024
On Wed, 4 Sep 2024 07:05:57 GMT, Tejesh R <tr at openjdk.org> wrote:
>>> null check might be required here.
>>
>> But we are not setting it as null anywhere in the code.
>
> What if its not initialized at first place? To handle this scenario most of the test has this condition.
I don't see a chance for that as the frame is initialized in createGUI() and there are lot of code which directly access frame object there itself, so if it was null, it would have thrown the Nullpointer even before. Anyway, I had this null check before, but removed it as per @honkar-jdk 's review comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20777#discussion_r1743194980
More information about the client-libs-dev
mailing list