RFR: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize [v4]

Tejesh R tr at openjdk.org
Wed Sep 4 07:28:18 UTC 2024


On Wed, 4 Sep 2024 07:14:14 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> What if its not initialized at first place? To handle this scenario most of the test has this condition.
>
> I don't see a chance for that as the frame is initialized in createGUI() and there are lot of code which directly access frame object there itself, so if it was null, it would have thrown the Nullpointer even before. Anyway, I had this null check before, but removed it as per @honkar-jdk 's review comment.

`Frame is assigned null after disposing which is not required and can be removed.` I hope u r referring to this comment. I hope she meant to remove null assignment after dispose is called.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20777#discussion_r1743210317


More information about the client-libs-dev mailing list