RFR: 8333403: Write a test to check various components events are triggered properly [v6]

Alexey Ivanov aivanov at openjdk.org
Wed Sep 4 16:15:30 UTC 2024


On Wed, 24 Jul 2024 19:23:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8333403: Review commnets fixed
>
> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 164:
> 
>> 162: 
>> 163:         robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
>> 164:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 
> Do you click the panel to ensure the frame has focus?
> 
> Does the test fail if the frame fails to be the active frame for whatever reason? (It should always be the active frame / window.)

You didn't answer the question and marked it resolved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1743984396


More information about the client-libs-dev mailing list