RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java test failed on linux machine [v3]
Harshitha Onkar
honkar at openjdk.org
Wed Sep 4 20:55:19 UTC 2024
On Wed, 4 Sep 2024 05:48:53 GMT, Tejesh R <tr at openjdk.org> wrote:
>> Test failed intermittently on particular host. Though analysis pointed out to a test frame at left top on that host, I've updated the test for further stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis reports where the image didn't had exact black color which is supposed to be. So like other test cases, providing some tolerance for comparison.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>
> Updated based on review comments
> I'm okay with color tolerance set to 10 but if a smaller value works for this test (in CI testing) then it might be better to be more restrictive with color tolerance.
LGTM other than the color tolerance comment as mentioned above.
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20723#pullrequestreview-2281285836
More information about the client-libs-dev
mailing list