RFR: 8339902: Open source couple TextField related tests

Harshitha Onkar honkar at openjdk.org
Mon Sep 16 23:38:05 UTC 2024


On Mon, 16 Sep 2024 23:02:58 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and open source five TextField related tests: 
> java/awt/TextField/CaretPositionTest;
> java/awt/TextField/SetBoundsTest;
> java/awt/TextField/SetEchoCharTest4;
> java/awt/TextField/SetPasswordTest;
> java/awt/TextField/ZeroEchoCharTest

Changes requested by honkar (Reviewer).

Changes requested by honkar (Reviewer).

test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 53:

> 51:     private static int position = -1;
> 52: 
> 53:     public static void main(String[] args) throws InterruptedException,

Can be simplified to throw generic Exception
Suggestion:

    public static void main(String[] args) throws Exception

test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 80:

> 78:     }
> 79: 
> 80:     public void test() throws AWTException, InterruptedException,

Suggestion:

    public void test() throws Exception,

test/jdk/java/awt/TextField/SetBoundsTest/SetBoundsTest.java line 39:

> 37: /*
> 38:  * @test
> 39:  * @bug 6198290, 6277332

Test fails due to comma between bugIDs - Invalid or unrecognized bugid: 6198290

test/jdk/java/awt/TextField/SetBoundsTest/SetBoundsTest.java line 41:

> 39:  * @bug 6198290, 6277332
> 40:  * @summary TextField painting is broken when placed on a Scrollpane, XToolkit
> 41:  * @library /open/test/jdk/java/awt/regtesthelpers

Library path needs to be updated
Suggestion:

 * @library /java/awt/regtesthelpers

-------------

PR Review: https://git.openjdk.org/jdk/pull/21026#pullrequestreview-2307989995
PR Review: https://git.openjdk.org/jdk/pull/21026#pullrequestreview-2307995012
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762078525
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762078021
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762082561
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762083157


More information about the client-libs-dev mailing list