RFR: 8339902: Open source couple TextField related tests [v3]

Alexander Zuev kizune at openjdk.org
Tue Sep 17 00:11:30 UTC 2024


On Mon, 16 Sep 2024 23:27:34 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Some fixes based on review
>
> test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 80:
> 
>> 78:     }
>> 79: 
>> 80:     public void test() throws AWTException, InterruptedException,
> 
> Suggestion:
> 
>     public void test() throws Exception,

I prefer to list all the exceptions i am intentionally do not catch.

> test/jdk/java/awt/TextField/SetEchoCharTest4/SetEchoCharTest4.java line 37:
> 
>> 35:  * @bug 4226580
>> 36:  * @summary TextField with echoChar add+remove+add seems to be broken
>> 37:  * @library /open/test/jdk/java/awt/regtesthelpers
> 
> Same here. Library path needs to be updated and applicable to other tests as well.

Fixed here and in all other places.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762103428
PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762103716


More information about the client-libs-dev mailing list