RFR: 8340078: Open source several 2D tests

Harshitha Onkar honkar at openjdk.org
Wed Sep 18 01:00:10 UTC 2024


On Tue, 17 Sep 2024 18:27:58 GMT, Phil Race <prr at openjdk.org> wrote:

> Open source 5 Java2D related rendering tests.

Other than the following minor comments and the lib path mentioned here https://github.com/openjdk/jdk/pull/21045#discussion_r1763925919 , everything else looks good.

test/jdk/sun/java2d/SunGraphics2D/RevalidateBug.java line 34:

> 32:  */
> 33: 
> 34: import java.awt.Color;

Unused import.

test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 31:

> 29: 
> 30: import java.awt.Color;
> 31: import static java.awt.Color.*;

static import redudant here.

test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 38:

> 36: public class ScaledPolyTest {
> 37: 
> 38:     public static void main(String argv[]) {

Suggestion:

    public static void main(String[] argv) {

-------------

PR Review: https://git.openjdk.org/jdk/pull/21045#pullrequestreview-2311400355
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1764249465
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1764248906
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1764249519


More information about the client-libs-dev mailing list