RFR: 8340078: Open source several 2D tests

Phil Race prr at openjdk.org
Wed Sep 18 17:46:16 UTC 2024


On Wed, 18 Sep 2024 00:48:59 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Open source 5 Java2D related rendering tests.
>
> test/jdk/sun/java2d/SunGraphics2D/RevalidateBug.java line 34:
> 
>> 32:  */
>> 33: 
>> 34: import java.awt.Color;
> 
> Unused import.

? I use Color multiple times.

> test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 31:
> 
>> 29: 
>> 30: import java.awt.Color;
>> 31: import static java.awt.Color.*;
> 
> static import redudant here.

fixed

> test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 38:
> 
>> 36: public class ScaledPolyTest {
>> 37: 
>> 38:     public static void main(String argv[]) {
> 
> Suggestion:
> 
>     public static void main(String[] argv) {

either is OK but since I'm updating the file anyway

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765466132
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765466027
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765467367


More information about the client-libs-dev mailing list