RFR: 8339984: Open source AWT MenuItem related tests [v10]
Alexey Ivanov
aivanov at openjdk.org
Wed Sep 18 15:30:14 UTC 2024
On Wed, 18 Sep 2024 15:07:57 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Test instruction update
Huh, I found another issue.
test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 107:
> 105: setMenuBar(mb);
> 106: setSize(450, 150);
> 107: }
The original test had `setVisible(true);` here. This is why the loop contains `setVisible(false)`.
Without showing the frames, the test may not reproduce the original problem reported in [JDK-4175790](https://bugs.openjdk.org/browse/JDK-4175790).
-------------
Changes requested by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2313064053
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1765278585
More information about the client-libs-dev
mailing list