RFR: 8339984: Open source AWT MenuItem related tests [v10]

Abhishek Kumar abhiscxk at openjdk.org
Wed Sep 18 15:42:10 UTC 2024


On Wed, 18 Sep 2024 15:26:51 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test instruction update
>
> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 107:
> 
>> 105:             setMenuBar(mb);
>> 106:             setSize(450, 150);
>> 107:         }
> 
> The original test had `setVisible(true);` here. This is why the loop contains `setVisible(false)`.
> 
> Without showing the frames, the test may not reproduce the original problem reported in [JDK-4175790](https://bugs.openjdk.org/browse/JDK-4175790).

I think the testFrame's are made invisible and disposed just after creating. Only the last frame and first frame is visible.
After the test update, **testFrame and firstFrame is setVisible by PassFailJFrame**.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1765299255


More information about the client-libs-dev mailing list