RFR: 8339984: Open source AWT MenuItem related tests [v13]
Alexey Ivanov
aivanov at openjdk.org
Thu Sep 19 16:15:39 UTC 2024
On Thu, 19 Sep 2024 16:08:09 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> TestFrame var declared as local var
Except for the minor nit, looks good to me now.
test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 75:
> 73: @Override
> 74: public void componentShown(ComponentEvent e) {
> 75: TestFrame testFrame;
I'd rather declare it before the loop — it's where `testFrame` is used.
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2316017874
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1767114783
More information about the client-libs-dev
mailing list