RFR: 8339984: Open source AWT MenuItem related tests [v13]

Abhishek Kumar abhiscxk at openjdk.org
Thu Sep 19 16:22:28 UTC 2024


On Thu, 19 Sep 2024 16:12:45 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   TestFrame var declared as local var
>
> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 75:
> 
>> 73:     @Override
>> 74:     public void componentShown(ComponentEvent e) {
>> 75:         TestFrame testFrame;
> 
> I'd rather declare it before the loop — it's where `testFrame` is used.

Ok... Need re-review.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1767121466


More information about the client-libs-dev mailing list