RFR: 8340393: Open source closed choice tests #2

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Sep 20 09:03:38 UTC 2024


On Thu, 19 Sep 2024 06:39:40 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> few manual tests to open source
> Tested on all platforms, all looks good.

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/java/awt/Choice/CheckChoiceTest.java line 29:

> 27: import java.awt.BorderLayout;
> 28: import java.awt.Choice;
> 29: import java.awt.Frame;

I guess it was decided that java.awt will come before javax.swing...

test/jdk/java/awt/Choice/DisabledList.java line 43:

> 41: 
> 42:     private static final String INSTRUCTIONS = """
> 43:             1) Switch checkbox

Shouldn't it be "Enable checkbox"?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21081#pullrequestreview-2317656604
PR Review Comment: https://git.openjdk.org/jdk/pull/21081#discussion_r1768231187
PR Review Comment: https://git.openjdk.org/jdk/pull/21081#discussion_r1768250456


More information about the client-libs-dev mailing list