RFR: 8340393: Open source closed choice tests #2 [v2]

[Alexander Zvegintsev]

On Fri, 20 Sep 2024 08:46:32 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8340433: Open source closed choice tests #3
>
> test/jdk/java/awt/Choice/CheckChoiceTest.java line 29:
> 
>> 27: import java.awt.BorderLayout;
>> 28: import java.awt.Choice;
>> 29: import java.awt.Frame;
> 
> I guess it was decided that java.awt will come before javax.swing...

updated.

> test/jdk/java/awt/Choice/DisabledList.java line 43:
> 
>> 41: 
>> 42:     private static final String INSTRUCTIONS = """
>> 43:             1) Switch checkbox
> 
> Shouldn't it be "Enable checkbox"?

I would read the "Enable checkbox" as somehow related to `setEnabled`, but the component is already enabled.
So I'll keep it as it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21081#discussion_r1768266361
PR Review Comment: https://git.openjdk.org/jdk/pull/21081#discussion_r1768266326