RFR: 8340393: Open source closed choice tests #2 [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Sep 20 09:21:38 UTC 2024


On Fri, 20 Sep 2024 09:13:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> test/jdk/java/awt/Choice/DisabledList.java line 43:
>> 
>>> 41: 
>>> 42:     private static final String INSTRUCTIONS = """
>>> 43:             1) Switch checkbox
>> 
>> Shouldn't it be "Enable checkbox"?
>
> I would read the "Enable checkbox" as somehow related to `setEnabled`, but the component is already enabled.
> So I'll keep it as it is.

As per Checkbox spec
"A check box is a graphical component that can be in either an "on" (true) or "off" (false) state"
so I guess "Switch on checkbox" would be more apt.. To me atleast, "switch checkbox" doesn't sound perfect...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21081#discussion_r1768273607


More information about the client-libs-dev mailing list