RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v3]

Harshitha Onkar honkar at openjdk.org
Thu Sep 26 18:12:36 UTC 2024


On Wed, 25 Sep 2024 07:04:38 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Merge master
>>  - problemlist updated
>>  - eof newline
>>  - checkbox tests
>
> test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java line 43:
> 
>> 41:     private static final String INSTRUCTIONS = """
>> 42:             This test must be run at UI Scale of 100% OR 150% or greater.
>> 43:             Compare the size of box to any of native apps on Windows
> 
> Maybe you can mention anyone of the native app for easy verification...
> Also, it seems if tester tests with 100%, it might look same and tester can pass it...I guess the problem comes with hidpi scale of 150% or more, so maybe we can remove 100% from instruction OR mention 100% AND 150% to check for both...

Updated instructions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1777543178


More information about the client-libs-dev mailing list