RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v3]

Harshitha Onkar honkar at openjdk.org
Thu Sep 26 18:28:56 UTC 2024


On Wed, 25 Sep 2024 07:07:22 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Merge master
>>  - problemlist updated
>>  - eof newline
>>  - checkbox tests
>
> test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java line 65:
> 
>> 63:             Verify that all indicators of checkboxes has the same size.
>> 64:             Verify that all indicators of radio buttons has the same size.
>> 65:             Press PASS if the above conditions are true else Press FAIL.
> 
> I guess "Same size" is not correct here...I guess what we meant is the size should be proportionate to scaling or "size will change if font size is changed", it seems the size does not increase if we increase the scale..
> but it still remains the "same", so some tester can consider it pass

@prsadhuk I have a clarification about this: 
Does thecheckbox size depend on label size (font size) and they need to be scaled proportionately or is the size dependent only on uiScale?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1777560509


More information about the client-libs-dev mailing list