RFR: JDK-8340555 : Open source DnD tests - Set4 [v3]

[Alexey Ivanov]

On Fri, 27 Sep 2024 04:17:30 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are added as part of this PR:
>> 
>> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual PassFailJFrame (PFJ) test**, problemlisted on all platforms.
>> 
>> 2. java/awt/dnd/DragSourceMotionListenerTest.java -  **Automated test**, problemlisted on windows
>> 
>> 3. /java/awt/dnd/DragToAnotherScreenTest.java - **Manual PFJ test**
>> 
>> 4. /java/awt/dnd/RejectDragTest.java - **Automated test**, problemlisted on macOS
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   unused imports

test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.html line 1:

> 1: <!--

Can we create the file on-the-fly from a string in a source file?

It looks the file is required for the test.

test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.java line 46:

> 44: import java.nio.file.Paths;
> 45: 
> 46: class DnDSource extends Button implements Transferable,

This class can likely be a static nested class inside `DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java`.

If both the HTML and DnDSource are within `DnDHTMLToOutlookTest.java`, the test becomes self-sufficient. And the folder can be omitted.

test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.java line 76:

> 74:         if (dir == null) {
> 75:             dir = ".";
> 76:         }

Suggestion:

        String dir = System.getProperty("test.src", ".");

test/jdk/java/awt/dnd/DragToAnotherScreenTest.java line 43:

> 41: /*
> 42:  * @test
> 43:  * @bug 6179157

Shall we add `@key multimon`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779072015
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779075989
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779076939
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779078385