RFR: JDK-8340555 : Open source DnD tests - Set4 [v3]

[Harshitha Onkar]

On Fri, 27 Sep 2024 19:35:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   unused imports
>
> test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.html line 1:
> 
>> 1: <!--
> 
> Can we create the file on-the-fly from a string in a source file?
> 
> It looks the file is required for the test.

At this point I'll leave it as a separate .html file.

> test/jdk/java/awt/dnd/DnDHTMLToOutlookTest/DnDSource.java line 46:
> 
>> 44: import java.nio.file.Paths;
>> 45: 
>> 46: class DnDSource extends Button implements Transferable,
> 
> This class can likely be a static nested class inside `DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java`.
> 
> If both the HTML and DnDSource are within `DnDHTMLToOutlookTest.java`, the test becomes self-sufficient. And the folder can be omitted.

Yes, although keeping it separate makes the test look cleaner.

> test/jdk/java/awt/dnd/DragToAnotherScreenTest.java line 43:
> 
>> 41: /*
>> 42:  * @test
>> 43:  * @bug 6179157
> 
> Shall we add `@key multimon`?

This test is applicable for single monitors as well. Does `@key multimon` mean muti-monitor setup only ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779097185
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779094108
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1779093711