RFR: JDK-8340332 : Open source mixed AWT tests - Set3

[Alexey Ivanov]

On Mon, 30 Sep 2024 18:13:50 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> test/jdk/java/awt/MouseInfo/ContainerResizeMousePositionTest.java line 95:
>> 
>>> 93: 
>>> 94:         if (!eventCaught.await(2, TimeUnit.SECONDS)) {
>>> 95:             if (!testSucceeded) {
>> 
>> These two conditions look independent.
>> 
>> If `eventCaught.await` returned `false`, the test should fail with a timeout.
>> 
>> Otherwise, the test fails if `testSucceeded` didn't become `true`.
>
> Did you mean this way ? Condition updated
> 
> 
>         if (eventCaught.await(2, TimeUnit.SECONDS)) {
>             if (!testSucceeded) {
>                 throw new RuntimeException("Test Failed: Container.getMousePosition(boolean)"
>                                            + " returned incorrect result while Container resized");
>             }
>         } else {
>             throw new RuntimeException("Test timeout: Didn't receive"
>                                        + " Component Resized Event");
>         }

I'd rather not put them into one condition either, even though the condition above looks correct.


        if (!eventCaught.await(2, TimeUnit.SECONDS)) {
            throw new RuntimeException("componentResized isn't received within a timeout");
        }

        if (!testSucceeded) {
            throw new RuntimeException("Container.getMousePosition(boolean)"
                                       + " returned incorrect result while Container resized");
        }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21271#discussion_r1781575360