RFR: JDK-8340332 : Open source mixed AWT tests - Set3 [v2]

Harshitha Onkar honkar at openjdk.org
Mon Sep 30 18:42:56 UTC 2024


On Mon, 30 Sep 2024 18:26:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Did you mean this way ? Condition updated
>> 
>> 
>>         if (eventCaught.await(2, TimeUnit.SECONDS)) {
>>             if (!testSucceeded) {
>>                 throw new RuntimeException("Test Failed: Container.getMousePosition(boolean)"
>>                                            + " returned incorrect result while Container resized");
>>             }
>>         } else {
>>             throw new RuntimeException("Test timeout: Didn't receive"
>>                                        + " Component Resized Event");
>>         }
>
> I'd rather not put them into one condition either, even though the condition above looks correct.
> 
> 
>         if (!eventCaught.await(2, TimeUnit.SECONDS)) {
>             throw new RuntimeException("componentResized isn't received within a timeout");
>         }
> 
>         if (!testSucceeded) {
>             throw new RuntimeException("Container.getMousePosition(boolean)"
>                                        + " returned incorrect result while Container resized");
>         }

After re-reading the comment it makes sense to keep it separate. Thanks. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21271#discussion_r1781589442


More information about the client-libs-dev mailing list