RFR: 8334016: Make PrintNullString.java semi-automatic

Mikhail Yankelevich myankelevich at openjdk.org
Tue Apr 8 13:40:18 UTC 2025


On Tue, 8 Apr 2025 08:58:45 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

> Hi Reviewers,
> 
> I have updated the test and made it semi-automatic (need to click "Print") . Test will initiate a print and result will be generated automatic. 
> 
> Please review and let me know your suggestions.

test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 64:

> 62:                 .columns(45)
> 63:                 .build();
> 64:         new PrintNullString();

Minor: Don't you think It's a bit unusual to have the test be executed with the builder of the class? Seems a bit odd to me, but if you prefer it, it's fine as is

test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 112:

> 110:             // API 1: null & empty drawString(String, int, int);
> 111:             try {
> 112:                 g2d.drawString(nullStr, 20, 40);

Isn't it always null? Don't you think it is a bit misleading when reading the test? 

Also applies to the lines 123, 134, 149

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24501#discussion_r2033214637
PR Review Comment: https://git.openjdk.org/jdk/pull/24501#discussion_r2033214366


More information about the client-libs-dev mailing list