RFR: 8334016: Make PrintNullString.java semi-automatic
Renjith Kannath Pariyangad
rkannathpari at openjdk.org
Wed Apr 9 03:54:24 UTC 2025
On Tue, 8 Apr 2025 13:37:25 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
>> Hi Reviewers,
>>
>> I have updated the test and made it semi-automatic (need to click "Print") . Test will initiate a print and result will be generated automatic.
>>
>> Please review and let me know your suggestions.
>
> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 64:
>
>> 62: .columns(45)
>> 63: .build();
>> 64: new PrintNullString();
>
> Minor: Don't you think It's a bit unusual to have the test be executed with the builder of the class? Seems a bit odd to me, but if you prefer it, it's fine as is
This **builder** is for PassFailJFrame (user instruction window).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24501#discussion_r2034394475
More information about the client-libs-dev
mailing list