RFR: 8352682: Opensource JComponent tests [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Mon Apr 14 12:54:28 UTC 2025
On Fri, 11 Apr 2025 16:42:54 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Use lambda
>
> test/jdk/javax/swing/JComponent/bug4247610.java line 103:
>
>> 101: robot.delay(200);
>> 102: robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
>> 103: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
>
> Is is good to add some delay after button click ?
No, it will add unnecessary delay and therefore unnecessary repaints which we are testing for..
> test/jdk/javax/swing/JComponent/bug4247610.java line 110:
>
>> 108:
>> 109: private static volatile boolean traceFlag;
>> 110: private static volatile boolean passFlag = true;
>
> Can be moved to the top along with other variable declarations
ok..done..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24562#discussion_r2041398716
PR Review Comment: https://git.openjdk.org/jdk/pull/24562#discussion_r2041398829
More information about the client-libs-dev
mailing list