RFR: 8352682: Opensource JComponent tests [v2]
Harshitha Onkar
honkar at openjdk.org
Fri Apr 11 16:53:27 UTC 2025
On Thu, 10 Apr 2025 12:32:02 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Few JComponent tests are opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Use lambda
test/jdk/javax/swing/JComponent/bug4247610.java line 103:
> 101: robot.delay(200);
> 102: robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
> 103: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
Is is good to add some delay after button click ?
test/jdk/javax/swing/JComponent/bug4247610.java line 110:
> 108:
> 109: private static volatile boolean traceFlag;
> 110: private static volatile boolean passFlag = true;
Can be moved to the top along with other variable declarations
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24562#discussion_r2039914191
PR Review Comment: https://git.openjdk.org/jdk/pull/24562#discussion_r2039921991
More information about the client-libs-dev
mailing list