RFR: 8352682: Opensource JComponent tests [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Apr 14 12:54:13 UTC 2025


On Fri, 11 Apr 2025 13:16:58 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use lambda
>
> test/jdk/javax/swing/JComponent/bug4247610.java line 29:
> 
>> 27:  * @summary Tests an unnecessary repaint issue
>> 28:  * @key headful
>> 29:  * @run main bug4247610
> 
> Nitpick: is this needed?

no harm in keeping it

> test/jdk/javax/swing/JComponent/bug4247610.java line 59:
> 
>> 57:         Robot robot = new Robot();
>> 58:         SwingUtilities.invokeAndWait(() -> {
>> 59:             frame = new JFrame("bug4247610");
> 
> Do you think this might cleaner if it was initialised at line 51? Also would allow to make it final

we need to do it in EDT

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24562#discussion_r2041397922
PR Review Comment: https://git.openjdk.org/jdk/pull/24562#discussion_r2041398110


More information about the client-libs-dev mailing list