RFR: 8354873: javax/swing/plaf/metal/MetalIconFactory/bug4952462.java failing on CI [v2]
Damon Nguyen
dnguyen at openjdk.org
Wed Apr 16 17:13:43 UTC 2025
> Test has a check for a red-ish color, but the range for the green and the blue values were too loose. A light enough grey would still pass (ex: 200, 190, 190). Reduced these from 200 to 80. Checked the color 200, 80, 80 on an rgb color wheel to decide that this color was red enough as the beginning to a passing rgb value.
Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
Review comments
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24693/files
- new: https://git.openjdk.org/jdk/pull/24693/files/5294aaff..494930d0
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24693&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24693&range=00-01
Stats: 49 lines in 1 file changed: 13 ins; 21 del; 15 mod
Patch: https://git.openjdk.org/jdk/pull/24693.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24693/head:pull/24693
PR: https://git.openjdk.org/jdk/pull/24693
More information about the client-libs-dev
mailing list