RFR: 8354873: javax/swing/plaf/metal/MetalIconFactory/bug4952462.java failing on CI [v2]
Harshitha Onkar
honkar at openjdk.org
Wed Apr 16 17:18:56 UTC 2025
On Wed, 16 Apr 2025 17:13:43 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> Test has a check for a red-ish color, but the range for the green and the blue values were too loose. A light enough grey would still pass (ex: 200, 190, 190). Reduced these from 200 to 80. Checked the color 200, 80, 80 on an rgb color wheel to decide that this color was red enough as the beginning to a passing rgb value.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments
Marked as reviewed by honkar (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/24693#pullrequestreview-2773279691
More information about the client-libs-dev
mailing list