RFR: 8353445: Open source several AWT Menu tests - Batch 1

Phil Race prr at openjdk.org
Wed Apr 16 20:59:48 UTC 2025


On Tue, 15 Apr 2025 06:14:33 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open source these AWT Menu tests:
> 
> java/awt/Menu/MenuVisibilityTest/MenuVisibilityTest.java
> java/awt/Menu/MenuActionEventTest/MenuActionEventTest.java
> java/awt/Menu/RmInHideTest/RmInHideTest.java
> java/awt/Menu/SetShortCutTest/SetShortCutTest.java

test/jdk/java/awt/Menu/MenuActionEventTest.java line 45:

> 43:         String INSTRUCTIONS = """
> 44:                 1. Click on the Menu and then on Menuitem on the frame.
> 45:                 2. If you find the following message being printed:,

printed in the test log area ...

test/jdk/java/awt/Menu/MenuActionEventTest.java line 73:

> 71: }
> 72: 
> 73: class _Menu extends Menu {

can all these additional classes be static nested classes ?

test/jdk/java/awt/Menu/MenuVisibilityTest.java line 43:

> 41:                 1. Press on a MenuBar with a long name.
> 42:                 2. Select "First item" in an opened menu.
> 43:                    If you see that "First menu item was pressed" press PASS

see it where ? tell the tester where to look.

test/jdk/java/awt/Menu/MenuVisibilityTest.java line 47:

> 45:                  """;
> 46:         PassFailJFrame.builder()
> 47:                 .title("Test Instructions")

no need for that

test/jdk/java/awt/Menu/RmInHideTest.java line 81:

> 79: }
> 80: 
> 81: class RmInHideTestFrame extends Frame implements ActionListener {

static nested ?

test/jdk/java/awt/Menu/SetShortCutTest.java line 73:

> 71: }
> 72: 
> 73: class TestMenuShortCut extends Frame implements ActionListener {

static nested ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2047738583
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2047737805
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2047741366
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2047741855
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2047746287
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2047750939


More information about the client-libs-dev mailing list