RFR: 8353445: Open source several AWT Menu tests - Batch 1 [v2]

[Tejesh R]

On Wed, 16 Apr 2025 20:51:27 GMT, Phil Race <prr at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated review comments
>
> test/jdk/java/awt/Menu/MenuActionEventTest.java line 45:
> 
>> 43:         String INSTRUCTIONS = """
>> 44:                 1. Click on the Menu and then on Menuitem on the frame.
>> 45:                 2. If you find the following message being printed:,
> 
> printed in the test log area ...

Updated.

> test/jdk/java/awt/Menu/MenuActionEventTest.java line 73:
> 
>> 71: }
>> 72: 
>> 73: class _Menu extends Menu {
> 
> can all these additional classes be static nested classes ?

Updated.

> test/jdk/java/awt/Menu/MenuVisibilityTest.java line 43:
> 
>> 41:                 1. Press on a MenuBar with a long name.
>> 42:                 2. Select "First item" in an opened menu.
>> 43:                    If you see that "First menu item was pressed" press PASS
> 
> see it where ? tell the tester where to look.

Updated.

> test/jdk/java/awt/Menu/MenuVisibilityTest.java line 47:
> 
>> 45:                  """;
>> 46:         PassFailJFrame.builder()
>> 47:                 .title("Test Instructions")
> 
> no need for that

Updated.

> test/jdk/java/awt/Menu/RmInHideTest.java line 81:
> 
>> 79: }
>> 80: 
>> 81: class RmInHideTestFrame extends Frame implements ActionListener {
> 
> static nested ?

Updated.

> test/jdk/java/awt/Menu/SetShortCutTest.java line 73:
> 
>> 71: }
>> 72: 
>> 73: class TestMenuShortCut extends Frame implements ActionListener {
> 
> static nested ?

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2048682970
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2048682875
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2048683046
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2048683139
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2048683207
PR Review Comment: https://git.openjdk.org/jdk/pull/24649#discussion_r2048683271