RFR: 8354365: Opensource few Modal and Full Screen related tests [v2]

Hendrik Schick duke at openjdk.org
Thu Apr 17 11:18:53 UTC 2025


On Thu, 17 Apr 2025 06:31:03 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few Modal and Full Screen related tests are converted from applet and open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix

test/jdk/java/awt/FullScreen/NonfocusableFrameFullScreenTest.java line 59:

> 57:                 3. Press "To Windowed" button:
> 58:                         The frame should return to its original size.
> 59:                         The frame shouldn't be alwayOnTop.

Suggestion:

                        The frame shouldn't be alwaysOnTop.

?

test/jdk/java/awt/FullScreen/NonfocusableFrameFullScreenTest.java line 80:

> 78:     private NonfocusableFrameFullScreenTest() {
> 79:         Button b = new Button("Show Frame");
> 80:         b.addActionListener(new ActionListener() {

lambda can be used here and on subsequent action listeners.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24685#discussion_r2048734748
PR Review Comment: https://git.openjdk.org/jdk/pull/24685#discussion_r2048735333


More information about the client-libs-dev mailing list