RFR: 8354365: Opensource few Modal and Full Screen related tests [v2]

[Abhishek Kumar]

On Thu, 17 Apr 2025 11:14:02 GMT, Hendrik Schick <duke at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/java/awt/FullScreen/NonfocusableFrameFullScreenTest.java line 59:
> 
>> 57:                 3. Press "To Windowed" button:
>> 58:                         The frame should return to its original size.
>> 59:                         The frame shouldn't be alwayOnTop.
> 
> Suggestion:
> 
>                         The frame shouldn't be alwaysOnTop.
> 
> ?

updated

> test/jdk/java/awt/FullScreen/NonfocusableFrameFullScreenTest.java line 80:
> 
>> 78:     private NonfocusableFrameFullScreenTest() {
>> 79:         Button b = new Button("Show Frame");
>> 80:         b.addActionListener(new ActionListener() {
> 
> lambda can be used here and on subsequent action listeners.

Not the only way to be done. This seems good to me for now.

> test/jdk/java/awt/Modal/DialogLosesFocusTest.java line 105:
> 
>> 103:         try {
>> 104:             Thread.sleep(t);
>> 105:         } catch (Exception z) {}
> 
> Suggestion:
> 
>         } catch (Exception _) {}
> 
> should work to use an unnamed variable here?

Not mandatory.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24685#discussion_r2048841163
PR Review Comment: https://git.openjdk.org/jdk/pull/24685#discussion_r2048841055
PR Review Comment: https://git.openjdk.org/jdk/pull/24685#discussion_r2048838714