RFR: JDK-8353486 : Open source Swing Tests - Set 4 [v3]
Alexey Ivanov
aivanov at openjdk.org
Thu Apr 17 17:27:40 UTC 2025
On Tue, 8 Apr 2025 22:45:31 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Open-sourced the following Swing tests:
>>
>> 1. javax/swing/JFileChooser/bug4464774.java
>> 2. javax/swing/JFileChooser/bug4522756.java
>> 3. javax/swing/JFileChooser/bug4759934.java
>> 4. javax/swing/JFileChooser/bug4943900.java
>> 5. javax/swing/JOptionPane/bug4194862.java
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> review update
Only a partial review, I couldn't finish it today.
test/jdk/javax/swing/JFileChooser/bug4464774.java line 63:
> 61: public static JFrame createAndShowUI() {
> 62: JFrame frame = new JFrame("JFileChooser bug4464774");
> 63: JFileChooser jfc = new JFileChooser();
You can add `jfc.setControlButtonsAreShown(false)` to hide the **Open** and **Cancel** buttons.
This can be applied to all the `JFileChooser` tests.
-------------
PR Review: https://git.openjdk.org/jdk/pull/24456#pullrequestreview-2776469916
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2049379768
More information about the client-libs-dev
mailing list