RFR: JDK-8353486 : Open source Swing Tests - Set 4 [v3]

[Harshitha Onkar]

On Thu, 17 Apr 2025 17:21:14 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> test/jdk/javax/swing/JFileChooser/bug4943900.java line 43:
>> 
>>> 41:     private static final String INSTRUCTIONS = """
>>> 42:         1. Click "Show FileChooser" button below, FileChooser dialog must
>>> 43:            appear.
>> 
>> I do not see the "Show FileChooser" button, the file chooser showed automatically.
>> 
>> However, it is shown in an unobvious way (code-wise), via the `frame.add(fc);` call (and later the `setVisible(true)` call on the JFrame shows it).
>> 
>> Is this intentional?
>
> Updated instructions.
> I previously had "Show FileChooser" button on click of which jfc was shown but during the course of review got a suggestion to remove the extra button click and directly add it to the frame so that it doesn't cover the instruction UI.

Updated to remove redundant frame and simply return jfc.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2049524991