RFR: 8353957: Open source several AWT ScrollPane tests - Batch 1

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Apr 18 10:19:43 UTC 2025


On Wed, 16 Apr 2025 11:24:47 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open source these AWT ScrollPane tests:
> 
> java/awt/ScrollPane/ScrollPaneFlicker/ScrollPaneFlicker.java
> java/awt/ScrollPane/ScrollbarsAsNeeded/ScrollbarsAsNeededTest.java
> java/awt/ScrollPane/ScrollPanePaint/ScrollPanePaint.java
> java/awt/ScrollPane/ScrollPositionTest/ScrollPositionTest.java

test/jdk/java/awt/ScrollPane/ScrollPositionTest.java line 101:

> 99:             synchronized (ScrollPositionTest.lock) {
> 100:                 ScrollPositionTest.lock.notify();
> 101:             }

Better to use CountDownLatch than wait-notify but there is no lock.wait(timeout) so not sure whom it is notifying so it seems to be a no-op

test/jdk/java/awt/ScrollPane/ScrollbarsAsNeededTest.java line 58:

> 56:     static Frame initialize() {
> 57:         Frame frame = new Frame("Scrollbar as needed test");
> 58:         ScrollPane scrollPane = new java.awt.ScrollPane() {

expansion not needed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24684#discussion_r2050452536
PR Review Comment: https://git.openjdk.org/jdk/pull/24684#discussion_r2050454423


More information about the client-libs-dev mailing list