RFR: 8353957: Open source several AWT ScrollPane tests - Batch 1

Tejesh R tr at openjdk.org
Tue Apr 22 03:41:42 UTC 2025


On Fri, 18 Apr 2025 10:14:39 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Open source these AWT ScrollPane tests:
>> 
>> java/awt/ScrollPane/ScrollPaneFlicker/ScrollPaneFlicker.java
>> java/awt/ScrollPane/ScrollbarsAsNeeded/ScrollbarsAsNeededTest.java
>> java/awt/ScrollPane/ScrollPanePaint/ScrollPanePaint.java
>> java/awt/ScrollPane/ScrollPositionTest/ScrollPositionTest.java
>
> test/jdk/java/awt/ScrollPane/ScrollPositionTest.java line 101:
> 
>> 99:             synchronized (ScrollPositionTest.lock) {
>> 100:                 ScrollPositionTest.lock.notify();
>> 101:             }
> 
> Better to use CountDownLatch than wait-notify but there is no lock.wait(timeout) so not sure whom it is notifying so it seems to be a no-op

Then shall I remove it ?

> test/jdk/java/awt/ScrollPane/ScrollbarsAsNeededTest.java line 58:
> 
>> 56:     static Frame initialize() {
>> 57:         Frame frame = new Frame("Scrollbar as needed test");
>> 58:         ScrollPane scrollPane = new java.awt.ScrollPane() {
> 
> expansion not needed

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24684#discussion_r2053276209
PR Review Comment: https://git.openjdk.org/jdk/pull/24684#discussion_r2053277253


More information about the client-libs-dev mailing list