RFR: 8354472: Clean up and open source KeyEvent related tests (Part 3)

[Harshitha Onkar]

On Fri, 18 Apr 2025 22:23:25 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and publish five more KeyEvent related tests.

LGTM apart from minor suggestions.

test/jdk/java/awt/event/KeyEvent/CharUndefinedTest.java line 45:

> 43:             Click on the text field inside the window named "Check KeyChar values".
> 44:             Of any of the keys mentioned in this list that exist on your keyboard
> 45:             press once every of them and also press them in two-key combinations such as

Suggestion:

            press each of the listed keys once and also press them in two-key combinations such as

test/jdk/java/awt/event/KeyEvent/CharUndefinedTest.java line 48:

> 46:             Control-Shift or Alt-Control.
> 47:             The list of keys is: "Control, Shift, Meta, Alt, Command, Option".
> 48:             After that press once all function keys from F1 to F12,

Suggestion:

            After that press all function keys from F1 to F12 once,

test/jdk/java/awt/event/KeyEvent/CharUndefinedTest.java line 86:

> 84: 
> 85:     public static void main(String[] args) throws InterruptedException,
> 86:             InvocationTargetException {

generic exception can be used here and at other places. Not mandatory though.

Suggestion:

    public static void main(String[] args) throws Exception {

test/jdk/java/awt/event/KeyEvent/KeyEventToLightweight.java line 100:

> 98:         robot.waitForIdle();
> 99:         Point target = new Point();
> 100:         middleOf(lwbutton, target);

On EDT ?

test/jdk/java/awt/event/KeyEvent/KeyEventToLightweight.java line 114:

> 112:         robot.waitForIdle();
> 113:         robot.delay(500);
> 114:         middleOf(hwbutton, target);

on EDT ?

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24764#pullrequestreview-2779643001
PR Review Comment: https://git.openjdk.org/jdk/pull/24764#discussion_r2051259429
PR Review Comment: https://git.openjdk.org/jdk/pull/24764#discussion_r2051260646
PR Review Comment: https://git.openjdk.org/jdk/pull/24764#discussion_r2051262318
PR Review Comment: https://git.openjdk.org/jdk/pull/24764#discussion_r2051268071
PR Review Comment: https://git.openjdk.org/jdk/pull/24764#discussion_r2051268065