RFR: 8354472: Clean up and open source KeyEvent related tests (Part 3) [v2]

Alexander Zuev kizune at openjdk.org
Mon Apr 21 14:53:14 UTC 2025


On Sat, 19 Apr 2025 00:02:02 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update test/jdk/java/awt/event/KeyEvent/CharUndefinedTest.java
>>    
>>    Co-authored-by: Harshitha Onkar <harshitha.onkar at oracle.com>
>>  - Update test/jdk/java/awt/event/KeyEvent/CharUndefinedTest.java
>>    
>>    Co-authored-by: Harshitha Onkar <harshitha.onkar at oracle.com>
>
> test/jdk/java/awt/event/KeyEvent/CharUndefinedTest.java line 86:
> 
>> 84: 
>> 85:     public static void main(String[] args) throws InterruptedException,
>> 86:             InvocationTargetException {
> 
> generic exception can be used here and at other places. Not mandatory though.
> 
> Suggestion:
> 
>     public static void main(String[] args) throws Exception {

I prefer to list exactly the exceptions i expect to be thrown when possible - this way in the future i (or someone else) accidentally change something that introduces new exception it does not go unnoticed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24764#discussion_r2052520788


More information about the client-libs-dev mailing list