RFR: 8354472: Clean up and open source KeyEvent related tests (Part 3) [v3]
Alexander Zuev
kizune at openjdk.org
Mon Apr 21 15:00:07 UTC 2025
On Sat, 19 Apr 2025 00:08:49 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move middleOf calls to EDT.
>
> test/jdk/java/awt/event/KeyEvent/KeyEventToLightweight.java line 100:
>
>> 98: robot.waitForIdle();
>> 99: Point target = new Point();
>> 100: middleOf(lwbutton, target);
>
> On EDT ?
Yes in both cases. I even introduced this method to be called on EDT and then just forgot all about it :( Fixed.
> test/jdk/java/awt/event/KeyEvent/KeyEventToLightweight.java line 114:
>
>> 112: robot.waitForIdle();
>> 113: robot.delay(500);
>> 114: middleOf(hwbutton, target);
>
> on EDT ?
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24764#discussion_r2052534153
PR Review Comment: https://git.openjdk.org/jdk/pull/24764#discussion_r2052534376
More information about the client-libs-dev
mailing list